With all that out of the way, let's revisit what we've discussed above. And if there are problems with that approach, we should go and fix them in Electron so that everyone gets the benefits, not just us. So let's be mindful to keep the feature similar to the existing implementations, and not go overboard.įor things like opening files based on their file extension, we should be deferring to Electron and the file associations configured by the user at the OS level.
#Openlierox player profiles external editor code
The biggest bit of feedback we had from users of this feature over there was the lack of support their favourite editor (VS Code and Sublime were the most common request). We also want to keep in mind users migrating from the existing apps, which is why this is in scope for 1.0. Let's keep this feature focused, and get it polished and out sooner so we can get feedback and refine it quicker. The most important thing I want to call out here is that we don't want to go and overengineer something that may not fit the original problem. For the classic apps, the macOS version supported opening in Atom, and the Windows app was a bit smarter - it supported Atom too, but also Visual Studio (if you had it installed, and were in a repository with a. We want to make it easy for people to open a repository in their preferred editor. Looking at that last comment in #2039 (comment), it feels like we've not been clear enough with the scope of work here, so I'd like to apologise about not being more hands-on with guidance as that PR progressed, and take a bit here to clarify things before we go further. 🙃 Edit: This might be taken care of to some degree by #2039 The big problem with doing something like this is just checking if arbitrary editors are installed, and where they are installed to. Then down the road if you guys wanted to support other editors natively just change button into some sort of list/selection dialog in a "Select your preferred editor, or browse if it's not supported by default" sort of experience.
#Openlierox player profiles external editor full
The editor's name could be the full path, or you could have the path in the tooltip. Some editors might need to do something like "-OpenDirAsProject %1"
If you hover over (?) it should tell you what special values you can pass. | Command line options (?): "%1 (text input dialog)" | Currently selected editor: (Editors Icon) Editor's name | > External Editor to open repositories with:
0 kommentar(er)
